diff options
Diffstat (limited to 'ripple/fossil')
| -rw-r--r-- | ripple/fossil/src/lib.rs | 15 |
1 files changed, 14 insertions, 1 deletions
diff --git a/ripple/fossil/src/lib.rs b/ripple/fossil/src/lib.rs index 4cea16a..c79105c 100644 --- a/ripple/fossil/src/lib.rs +++ b/ripple/fossil/src/lib.rs @@ -66,6 +66,20 @@ impl Store { pub fn add_path(&self, path: impl AsRef<Path>) -> Node { let path = path.as_ref(); + let node = self.add_path_inner(path); + + // NOTE: sled *can* flush without us explicitly asking for it, so it's + // possible for the store to end up containing pointers to chunks that + // aren't fsynced yet. The easiest fix is to always `chunks_file.sync_data()` + // before we write anything to the database, but that's kind of a performance hazard. + // TODO(edef): keep pending and known-durable blobs/chunks separate in the database + self.chunks_file.borrow_mut().sync_data().unwrap(); + self.meta.flush().unwrap(); + + node + } + + fn add_path_inner(&self, path: &Path) -> Node { let meta = fs::symlink_metadata(path).unwrap(); match meta.file_type() { @@ -151,7 +165,6 @@ impl Store { buf }; - // TODO(edef): figure out fsync for durability (&self.blobs, &self.chunks, &self.meta) .transaction(|(blobs, chunks, meta)| { chunks.apply_batch(&batch)?; |